Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wit-bindgen and bump to 0.13.0 #81

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

alexcrichton
Copy link
Member

This commit updates wit-bindgen to 0.21.0 which brings in some minor updates to generated code in addition to a new wit-bindgen-rt crate dependency to use as well. This avoids the need to depend on the wit-bindgen crate at all through some updated options to the CLI bindings generator.

Additionally this bumps the crate to 0.13.0 to release these updated change in addition to the refactoring for the export-related macros previously.

This commit updates wit-bindgen to 0.21.0 which brings in some minor
updates to generated code in addition to a new `wit-bindgen-rt` crate
dependency to use as well. This avoids the need to depend on the
`wit-bindgen` crate at all through some updated options to the CLI
bindings generator.

Additionally this bumps the crate to 0.13.0 to release these updated
change in addition to the refactoring for the export-related macros
previously.
@sunfishcode
Copy link
Member

This commit updates wit-bindgen to 0.21.0 which brings in some minor updates to generated code in addition to a new wit-bindgen-rt crate dependency to use as well. This avoids the need to depend on the wit-bindgen crate at all through some updated options to the CLI bindings generator.

What is the advantage of not depending on wit-bindgen? We depend on bitflags either way, and wit-bindgen itself appears to have very little in it other than re-exports of wit-bindgen-rt. Is it the code in the pre_wit_bindgen_0_20_0 module?

@alexcrichton
Copy link
Member Author

Oh no real advantage per-se, but I figure it's at least a bit nicer in terms of "fewer deps" and better aligns with what cargo component is doing. AFAIK there's no technical benefit for doing so.

@sunfishcode
Copy link
Member

Why is wit-bindgen-rt a separate crate? Would it make sense to just fold it into wit-bindgen?

@alexcrichton
Copy link
Member Author

That was motivated by bytecodealliance/cargo-component#241 where I believe the issue was that cargo add was conflicting with the default dependency injected by cargo component and it was easier to manage if cargo component didn't have to deal with the features of a wit-bindgen dependency at all.

@sunfishcode sunfishcode merged commit 7ba8ab1 into bytecodealliance:main Mar 12, 2024
5 checks passed
@alexcrichton alexcrichton deleted the bump branch March 12, 2024 19:52
sunfishcode added a commit to sunfishcode/rust-wasi that referenced this pull request Mar 19, 2024
As of bytecodealliance#81, this rustfmt-bindings.toml file is no longer used.
alexcrichton pushed a commit that referenced this pull request Mar 19, 2024
As of #81, this rustfmt-bindings.toml file is no longer used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants