Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅enable to run unit tests in .NET 472 #309

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

fforjan
Copy link
Contributor

@fforjan fforjan commented Jun 4, 2024

This enables to run unit test in .Net 472.

It also fixes one issue when using .Net472 - we found it when following the steps from the Readme.MD

@fforjan
Copy link
Contributor Author

fforjan commented Jun 4, 2024

Notice that build on linux only run for net80
image

While for windows, you would see:

Failed!  - Failed:    29, Passed:   160, Skipped:     2, Total:   191, Duration: 734 ms - Wasmtime.Tests.dll (net472)
Failed!  - Failed:    19, Passed:    80, Skipped:     0, Total:    99, Duration: 278 ms - Wasmtime.Tests.dll (net8.0)

@jsturtevant
Copy link
Contributor

@fforjan could you rebase this PR? I will take a closer look afterwards

@fforjan fforjan force-pushed the feature/enableNet472OnUnitTests branch from 38cd8bc to 60724e1 Compare July 1, 2024 13:47
@fforjan
Copy link
Contributor Author

fforjan commented Jul 2, 2024

@jsturtevant should be good now

@fforjan
Copy link
Contributor Author

fforjan commented Jul 8, 2024

@jsturtevant let me know if you would like me to do anything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants