Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update true==1 for cppbuild.sh #1420

Merged
merged 6 commits into from
Oct 13, 2023

Conversation

jbkyang-nvi
Copy link
Contributor

@jbkyang-nvi jbkyang-nvi commented Oct 4, 2023

change logic for true/false in cppbuild

tritonserver/cppbuild.sh Outdated Show resolved Hide resolved
@jbkyang-nvi
Copy link
Contributor Author

jbkyang-nvi commented Oct 6, 2023

@saudet Did the changes. It seems like its failing on finding cmake. It doesn't seem like my changes will affect it. Am I missing something?

@saudet
Copy link
Member

saudet commented Oct 7, 2023

@saudet Did the changes. It seems like its failing on finding cmake. It doesn't seem like my changes will effect it. Am I missing something?

It's fixed now, sorry about that.

@jbkyang-nvi
Copy link
Contributor Author

Thanks Samuel! Look forward to seeing it merged 🙏

@saudet saudet merged commit 275be0b into bytedeco:master Oct 13, 2023
1 check passed
jbkyang-nvi added a commit to triton-inference-server/client that referenced this pull request Oct 13, 2023
jbkyang-nvi added a commit to triton-inference-server/client that referenced this pull request Oct 17, 2023
mc-nv pushed a commit to triton-inference-server/client that referenced this pull request Oct 17, 2023
fpetrini15 pushed a commit to triton-inference-server/perf_analyzer that referenced this pull request Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants