Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed segfault in LLVM Orc example #1501

Merged
merged 9 commits into from
Jun 2, 2024

Conversation

Minding000
Copy link
Contributor

@Minding000 Minding000 commented May 16, 2024

Issue

The LLVM ORC example segfaults when freeing error messages using LLVMConsumeError because LLVMGetErrorMessage already consumes the error.

Changes

  • Fixed error handling
  • Removed unnecessary initialization / function calls
  • Renamed Factorial example to MCJIT to highlight the difference between MCJIT and ORC
  • Added info that ORC is newer than MCJIT to the readme
  • Improved readability
  • Fixed typos

Notes

  • I tested all changes

llvm/README.md Outdated Show resolved Hide resolved
@saudet saudet merged commit ba67cea into bytedeco:master Jun 2, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants