Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundancies #192

Merged
merged 21 commits into from
Aug 16, 2019
Merged

Remove redundancies #192

merged 21 commits into from
Aug 16, 2019

Conversation

epeters3
Copy link
Contributor

@epeters3 epeters3 commented Aug 7, 2019

Closes #184. This PR makes these contributions:

  • Eliminate the need for metafeatures.json -- now the metadata used for the metafeature/resource computation only needs to be declared once; right where the computation method itself is declared.
  • Add facilities for specifying a metafeature's problem type and any associated metafeature groups.
  • Get rid of unused profile_distribution first return value.
  • Makes the data about the resources and which metafeatures are computed easier to read.
  • Factor out the constant strings from the Metafeatures class to a constants.py file, and refactor to always use those constants, rather than string literals sometimes.
  • Add a basic CONTRIBUTING.md guilde.

This PR eliminates 2981 lines of code from the codebase (by eliminating the metafeatures.json file).
Note: An overview of what has changed in this PR can be found in ./CONTRIBUTING.md

MANIFEST.in Outdated Show resolved Hide resolved
metalearn/metafeatures/base.py Outdated Show resolved Hide resolved
metalearn/metafeatures/base.py Outdated Show resolved Hide resolved
metalearn/metafeatures/base.py Outdated Show resolved Hide resolved
metalearn/metafeatures/base.py Outdated Show resolved Hide resolved
metalearn/metafeatures/base.py Outdated Show resolved Hide resolved
metalearn/metafeatures/constants.py Outdated Show resolved Hide resolved
metalearn/metafeatures/metafeatures.py Show resolved Hide resolved
metalearn/metafeatures/metafeatures.py Show resolved Hide resolved
metalearn/metafeatures/metafeatures.py Outdated Show resolved Hide resolved
metalearn/metafeatures/resources.py Outdated Show resolved Hide resolved
@bjschoenfeld bjschoenfeld self-assigned this Aug 8, 2019
@epeters3
Copy link
Contributor Author

Ok @bjschoenfeld and @macetheace96, I think I've addressed all your excellent comments and questions. Looking forward to any additional feedback you have before we merge this PR.

@bjschoenfeld bjschoenfeld merged commit 1db4714 into develop Aug 16, 2019
@bjschoenfeld bjschoenfeld deleted the remove-redundancies branch August 16, 2019 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CONTRIBUTING.md
3 participants