Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove compute time #203

Merged
merged 10 commits into from
Nov 14, 2019
Merged

Remove compute time #203

merged 10 commits into from
Nov 14, 2019

Conversation

emrysshevek
Copy link
Contributor

Closes #202, #169, and #196.

  • Adds a return_times flag (false by default) to determine whether to return compute times along with metafeature values or not.
  • Removes compute times from test dataset metafeatures
  • Put computation for X into a general resource computer so it can be timed
  • Added note in docstring and README about the timing function

@bjschoenfeld bjschoenfeld self-assigned this Nov 14, 2019
@codecov-io
Copy link

codecov-io commented Nov 14, 2019

Codecov Report

Merging #203 into develop will decrease coverage by 0.17%.
The diff coverage is 80%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #203      +/-   ##
===========================================
- Coverage    92.54%   92.36%   -0.18%     
===========================================
  Files           13       13              
  Lines          751      760       +9     
===========================================
+ Hits           695      702       +7     
- Misses          56       58       +2
Impacted Files Coverage Δ
...talearn/metafeatures/general_resource_computers.py 96.96% <100%> (+0.09%) ⬆️
metalearn/metafeatures/metafeatures.py 95.83% <71.42%> (-0.84%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9274653...56899bc. Read the comment docs.

@bjschoenfeld bjschoenfeld merged commit ffe55fa into develop Nov 14, 2019
@bjschoenfeld bjschoenfeld deleted the remove_compute_time branch November 14, 2019 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timing
3 participants