Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design::deepCopy does not work correctly #304

Open
trharoldsen opened this issue Nov 8, 2017 · 3 comments
Open

Design::deepCopy does not work correctly #304

trharoldsen opened this issue Nov 8, 2017 · 3 comments
Assignees
Labels
Milestone

Comments

@trharoldsen
Copy link
Collaborator

Method was not updated for new structure like pseudopins and macros.

@nelsobe
Copy link
Member

nelsobe commented Dec 13, 2017

Note: be sure to address property copying when it is fixed since that does not work in the fixes of #314.

@trharoldsen
Copy link
Collaborator Author

As @nelsobe mentioned, the deep copy methods may prove troublesome to keep up to date with merges. Though I don't necessarily agree, there seems to be a willingness to add additional parameters to the base cell classes that will be difficult to keep up the deep copy up to date with.

One solution would be to move deep copy out of the primary clases and into its own class turning it into more of a second class object. Or we could completely move it over to the rscad repo and only keep what I need.

@trharoldsen
Copy link
Collaborator Author

What is the status of deep copy? Do we want to maintain it or remove it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants