Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Realign shrinker tests #274

Merged
merged 3 commits into from
May 1, 2023
Merged

Realign shrinker tests #274

merged 3 commits into from
May 1, 2023

Conversation

jmid
Copy link
Collaborator

@jmid jmid commented May 1, 2023

This little PR realigns the Shrink tests to reenable the shrinker benchmark from #177, meaning that the tests should be listed in the same order, and agree on their names.
While adjusting the title of the QCheck2 test, I realized it was testing for a different value than the QCheck(1) test (comparing apples to oranges) so I fixed that.

This whole setup is admittedly fragile, but I'm not bothered enough to fix it ATM.

@jmid jmid mentioned this pull request May 1, 2023
@jmid jmid force-pushed the realign-shrinker-tests branch from 608ecaf to 68cda7e Compare May 1, 2023 14:48
@jmid jmid force-pushed the realign-shrinker-tests branch from 68cda7e to 7fcebd2 Compare May 1, 2023 15:27
@jmid
Copy link
Collaborator Author

jmid commented May 1, 2023

Rebased on main after merging #275

@jmid
Copy link
Collaborator Author

jmid commented May 1, 2023

7 successful CI runs across Ubuntu, macOS and Windows before we hit a web-server failure causing the rest to be cancelled. I'll therefore go ahead and merge.

Another vote for #276

@jmid jmid merged commit e294b14 into c-cube:main May 1, 2023
@jmid jmid deleted the realign-shrinker-tests branch May 1, 2023 15:56
@jmid jmid mentioned this pull request May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant