Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make QCheck2.state.res immutable #291

Merged
merged 2 commits into from
Jul 4, 2024
Merged

Conversation

jmid
Copy link
Collaborator

@jmid jmid commented Jul 1, 2024

QCheck2 fails with compile time warnings:

File "src/core/QCheck2.ml", line 1570, characters 4-33:
1570 |     mutable res: 'a TestResult.t;
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Warning 69 [unused-field]: mutable record field res is never mutated.

I think this was just an oversight with the refactoring in connection with QCheck2.
The PR removes the warning and the test suite still passes.

@jmid jmid force-pushed the qcheck2-state-res-warning branch from c2fa923 to d6102ec Compare July 4, 2024 13:46
@jmid
Copy link
Collaborator Author

jmid commented Jul 4, 2024

Rebased on main and added a CHANGELOG entry

@jmid jmid merged commit 7f872f2 into c-cube:main Jul 4, 2024
11 checks passed
@jmid jmid deleted the qcheck2-state-res-warning branch July 4, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant