PPX: mutual recursion with records is now compiling. #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it gave an error: n is unbound It looks like if we have mutually recursive types (algebraic + record) It doesn't generate 'n' argument for record, because it thinks that a record is not recursive by itself. It was fixed by treating all mutually recurusive types as recursive ones. Signed-off-by: Kakadu <[email protected]>
Signed-off-by: Kakadu <[email protected]>
|
LGTM! FTR, I consider this a natural fix for the issue - and it even comes as a slight code simplification. Merging ... thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the code like below was not compiling because 'n' argument was being forgotten. I added a dirty hack of treating all types in mutual block as recursive. Don't know is it a right solution but it seems to help