Call onhide on each tooltip hide #1818
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 64.03% (diff: 100%)@@ master #1818 diff @@
==========================================
Files 1 1
Lines 4400 4401 +1
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 2818 2818
- Misses 1582 1583 +1
Partials 0 0
|
|
@johnsudaar thank you for your contribution. Before merging this we'll need you to add automated tests for this issue. |
|
and same thing to onshow event, fix please. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The onhide method of the tooltip api is only called when the tooltip is closed from the api.
This PR call this methods when the tooltip is closed from the api or from an internal reason.