Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEATURE: [indicator] Add VWAP indicator #1258

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

FEATURE: [indicator] Add VWAP indicator #1258

wants to merge 1 commit into from

Conversation

austin362667
Copy link
Collaborator

v2

@bbgokarma-bot
Copy link

Welcome back! @austin362667, This pull request may get 257 BBG.

@austin362667 austin362667 requested a review from c9s July 31, 2023 13:32
@c9s c9s changed the title Indicator: Add VWAP FEATURE: [indicator] Add VWAP indicator Jul 31, 2023
c9s
c9s reviewed Jul 31, 2023
View reviewed changes
pkg/indicator/v2/vwap.go
return s
}

func (s *VWAPStream) calculate() float64 {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to check both the rawCloseValues, rawVolumeValues length, because it could trigger twice since you have 2 update callbacks, or you can subscribe the KLine stream

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c9s c9s c9s left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@austin362667 @bbgokarma-bot @CLAassistant @c9s