Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: add more tradestats to SessionSymbolReport #1388

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

go-dockly
Copy link

Adding more tradestats

@bbgokarma-bot
Copy link

Hi @go-dockly,

This is KarmaBot, and we reward your contributions with tokens sent directly to your wallet to support development.

This pull request may get 554 BBG.

To receive BBG tokens, please provide your Polygon (can be Ethereum) address as an issue comment in this pull request, following this format:

polygon:0xAb5801a7D398351b8bE11C439e05C5B3259aeC9B

Once this pull request is merged, your BBG tokens will be transferred to your wallet.

--
If you're interested in our project, feel free to join our Telegram group https://t.me/bbgo_intl

Best,
KarmaBot

@go-dockly go-dockly changed the title WIP FEATURE tradestats FEATURE: add more tradestats to SessionSymbolReport Nov 6, 2023
@go-dockly
Copy link
Author

Need a review please

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 561 BBG

@c9s c9s enabled auto-merge November 8, 2023 16:29
@c9s
Copy link
Owner

c9s commented Nov 9, 2023

build failed

@c9s c9s disabled auto-merge November 9, 2023 04:00
@c9s
Copy link
Owner

c9s commented Nov 9, 2023

could you please rebase origin/main and squash these fixup commits? thanks

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 576 BBG

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 582 BBG

@c9s
Copy link
Owner

c9s commented Jan 6, 2024

@go-dockly any update on this?

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

const (
// DailyToAnnualFactor is the factor to scale daily observations to annual.
// Commonly defined as the number of public market trading days in a year.
DailyToAnnualFactor = 252 // todo does this apply to crypto at all?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

252 is an average number of trading days per year in stock market, see this link https://quant.stackexchange.com/questions/51677/why-multiply-stock-returns-with-sqrt252

I think crypto market live 365 days, no off days, so that DailyToAnnualFactor here must be 365

@lanphan
Copy link
Contributor

lanphan commented Mar 27, 2024

Hello @go-dockly

It's great to see your PR here, I really need this.
Please continue with your PR, I'm looking forward to it.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants