-
-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEATURE: add more tradestats to SessionSymbolReport #1388
base: main
Are you sure you want to change the base?
Conversation
Hi @go-dockly, This is KarmaBot, and we reward your contributions with tokens sent directly to your wallet to support development. This pull request may get 554 BBG. To receive BBG tokens, please provide your Polygon (can be Ethereum) address as an issue comment in this pull request, following this format:
Once this pull request is merged, your BBG tokens will be transferred to your wallet. -- Best, |
Need a review please |
Re-estimated karma: this pull request may get 561 BBG |
build failed |
could you please rebase origin/main and squash these fixup commits? thanks |
Re-estimated karma: this pull request may get 576 BBG |
Re-estimated karma: this pull request may get 582 BBG |
@go-dockly any update on this? |
|
const ( | ||
// DailyToAnnualFactor is the factor to scale daily observations to annual. | ||
// Commonly defined as the number of public market trading days in a year. | ||
DailyToAnnualFactor = 252 // todo does this apply to crypto at all? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
252 is an average number of trading days per year in stock market, see this link https://quant.stackexchange.com/questions/51677/why-multiply-stock-returns-with-sqrt252
I think crypto market live 365 days, no off days, so that DailyToAnnualFactor here must be 365
Hello @go-dockly It's great to see your PR here, I really need this. Thanks |
Adding more tradestats