Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix trim trailing error #11085

Merged
merged 3 commits into from
Oct 24, 2024
Merged

Fix trim trailing error #11085

merged 3 commits into from
Oct 24, 2024

Conversation

fuzhaoyuan
Copy link
Contributor

@fuzhaoyuan fuzhaoyuan commented Oct 16, 2024 •
edited
Loading

Describe changes proposed in this pull request:

  • Fix the trim trailing process that will cause array join error if all ga.values are commas only
  • Didn't add checking for the last comma as it seems to introduce errors

@fuzhaoyuan fuzhaoyuan marked this pull request as ready for review October 16, 2024 16:52
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@alisman alisman merged commit b2ce990 into cBioPortal:demo-rfc80-poc Oct 24, 2024
10 of 13 checks passed
@fuzhaoyuan fuzhaoyuan deleted the demo-rfc80-poc-fix-genetic-table branch October 24, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alisman alisman alisman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fuzhaoyuan @alisman @sheridancbio