Application layer checks (optional) in the network checker #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
October 3, 2017 12:48
…ving an expected message
|
That looks great @ralienpp. I’ll get down to review it further ASAP. I can already see it’s missing migrations, but I can add that :) |
|
I'd be glad to add them myself, but my knowledge of Django is superficial and rusty. If you can write a step-by-step guide, I will be able to follow it; otherwise I am not confident I won't mess up the existing ORM-related logic. Otherwise, I'm happy to write the purely network-related part. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ability to check if the server replies with a particular message, to ensure it is really alive.