feat: add flag to disable containers tooling (#1367)

[blackheaven]

No description provided.

[domenkozar]

Nice! Any chance to separate styling changes from the behavior change?

[blackheaven]

Actually it's enforced by the pre-commit hook.

I can try to make a first commit with only formatting, would it be okay?

[domenkozar]

That would be perfect, thank you!

[blackheaven]

done :)

[sandydoo]

Actually it's enforced by the pre-commit hook.

@blackheaven, are you sure it's not your editor's tooling doing the formatting? This doesn't look like nixpkgs-fmt to me. If it really is, I'll have to investigate why our hooks are broken.

[blackheaven]

@blackheaven, are you sure it's not your editor's tooling doing the formatting? This doesn't look like nixpkgs-fmt to me. If it really is, I'll have to investigate why our hooks are broken.

I think my language server formatted twice, anyway, it's fixed now.

[domenkozar]

The main reason why I haven't merged this yet is because I'm not convinced what the API should look like.

Maybe we should add something like containers.<name>.contents = []; that would imply to build the container from scratch?

[blackheaven]

@Mic92 Thank you so much!

[blackheaven]

Maybe we should add something like containers.<name>.contents = []; that would imply to build the container from scratch?

Should we check that for other parameters? (i.e. perms, etc.)