Add profile setting to isort hook #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
totoroot
pushed a commit
to totoroot/git-hooks.nix
that referenced
this pull request
Sep 9, 2023
…-hook Add profile setting to isort hook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the profile setting to the isort hook. I plan to add some other later if I find the time. There are a lot of CLI options for isort, so I have to check which ones make sense and which can just be passed as flags.
I also noticed that mkdocs-linkcheck hook was still not quite right, as enabling it, without declaring any settings, caused devenv to fail building the devShell. I fixed that now