-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit tests for activity task handler #1378
Unit tests for activity task handler #1378
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
||
require.True(t, util.AwaitWaitGroup(wg, time.Second)) | ||
}) | ||
t.Run("heartbeat fail", func(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not use table test to have less redundancy? this approach is hard to maintain especially while the function under test changes. requires changing N test bodies instead of 1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if I can save much with table tests.
I think a setup will have many customizations and be hard to read.
29c3fbe
to
ec10286
Compare
Detailed Description
To improve test coverage, I've moved existing components to separate files and added unit tests for the activity handler.
Impact Analysis
Testing Plan
Rollout Plan