Add unit tests for GetVersion #1389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3vilhamster
requested review from
Groxx,
shijiesheng,
jakobht,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
jakobht
approved these changes
Nov 6, 2024
3vilhamster
force-pushed
the
getversion-tests
branch
from
89e90b9 to
b295396
Compare
3vilhamster
force-pushed
the
getversion-tests
branch
from
b295396 to
3271d90
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Add unit tests for GetVersion and added a log for error in UpsertSearchAttributes.
The error handling is a noop and happens only if we cannot serialize data. This is not expected to happen with the existing GetVersion API.
Why?
Improving test coverage.
How did you test it?
Potential risks