Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added extra tests for terminate_workflow #6019

Merged
merged 1 commit into from
May 13, 2024

Conversation

agautam478
Copy link
Contributor

What changed?

  • this is the final diff for this file. the tests should have 93% coverage now.

Why?

How did you test it?

Potential risks

Release notes

Documentation Changes

@agautam478 agautam478 merged commit eda6188 into cadence-workflow:master May 13, 2024
18 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 018f7354-9794-410d-b6b3-94f680db86bb

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 123 unchanged lines in 13 files lost coverage.
  • Overall coverage increased (+0.02%) to 69.18%

Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 1 89.05%
common/persistence/execution_manager.go 2 83.74%
common/cache/lru.go 2 92.89%
common/util.go 2 91.78%
service/history/execution/context_util.go 2 89.31%
common/persistence/statsComputer.go 2 97.14%
service/history/task/fetcher.go 2 85.05%
common/task/fifo_task_scheduler.go 4 82.47%
service/frontend/wrappers/metered/metered.go 4 66.67%
service/matching/service.go 6 92.59%
Totals Coverage Status
Change from base Build 018f733c-6283-43e5-a128-8a560d4c9941: 0.02%
Covered Lines: 101643
Relevant Lines: 146926

💛 - Coveralls

timl3136 pushed a commit to timl3136/cadence that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants