Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scaffolding for CompleteStartedTask implementation in matching #6252

Draft
wants to merge 1 commit into
base: stale-tasks-passive-side-cleanup-feature-branch
Choose a base branch
from

Conversation

fimanishi
Copy link
Member

What changed?
Added scaffolding for the new IDL CompleteStartedTask implementation in matching. This endpoint will be called by the history service in order to complete a task in matching after it has been replicated in history.

Why?
This will allow cadence to actively delete stale tasks from matching on the passive side as these tasks are processed on the active side and replicated, avoiding the large passive side partitions and reducing task processing latency after a failover How did you test it?
This implements only the scaffolding. No logic present.

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 25 lines in your changes missing coverage. Please review.

Project coverage is 72.98%. Comparing base (c0cd4c5) to head (e4c4104).
Report is 5 commits behind head on master.

Files Patch % Lines
common/types/mapper/thrift/matching.go 0.00% 10 Missing ⚠️
common/types/mapper/proto/matching.go 0.00% 9 Missing ⚠️
service/matching/handler/engine.go 0.00% 3 Missing ⚠️
service/matching/handler/handler.go 0.00% 3 Missing ⚠️
Additional details and impacted files
Files Coverage Δ
common/types/matching.go 0.00% <ø> (ø)
service/matching/handler/engine.go 79.89% <0.00%> (-0.31%) ⬇️
service/matching/handler/handler.go 98.67% <0.00%> (-1.33%) ⬇️
common/types/mapper/proto/matching.go 92.91% <0.00%> (-2.44%) ⬇️
common/types/mapper/thrift/matching.go 95.34% <0.00%> (-3.85%) ⬇️

... and 14 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0cd4c5...e4c4104. Read the comment docs.

@fimanishi fimanishi changed the base branch from master to stale-tasks-passive-side-cleanup-feature-branch August 27, 2024 21:14
@fimanishi fimanishi changed the base branch from stale-tasks-passive-side-cleanup-feature-branch to master August 27, 2024 21:14
@fimanishi fimanishi force-pushed the complete-started-task-scaffolding branch from e4c4104 to d917552 Compare August 27, 2024 22:10
What changed?
Added scaffolding for the new IDL CompleteStartedTask implementation in matching. This endpoint will be called by the history service in order to complete a task in matching after it has been replicated in history.

Why?
This will allow cadence to actively delete stale tasks from matching on the passive side as these tasks are processed on the active side and replicated, avoiding the large passive side partitions and reducing task processing latency after a failover How did you test it?
This implements only the scaffolding. No logic present.

Potential risks

Release notes

Documentation Changes
@fimanishi fimanishi force-pushed the complete-started-task-scaffolding branch from d917552 to e1eba5b Compare August 27, 2024 22:31
@fimanishi fimanishi changed the base branch from master to stale-tasks-passive-side-cleanup-feature-branch August 27, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant