Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: increase ratelimit-burst-size for global use #6277

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Groxx
Copy link
Member

@Groxx Groxx commented Sep 10, 2024

unfortunately much more work than expected, due to how intertwined some of this is.

fully separating out frontend limits would probably simplify things, but there's more work to do to get there.

so this works when in "global" mode and it's reasonably simple.
this DOES NOT work in fallback mode though, and that's my real goal, because that's where much of these bursty requests fall.
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 73.10%. Comparing base (1771349) to head (05c121e).

Files with missing lines Patch % Lines
common/quotas/global/collection/collection.go 66.66% 5 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
common/quotas/dynamicratelimiter.go 76.92% <100.00%> (+10.25%) ⬆️
...mmon/quotas/global/collection/internal/fallback.go 96.49% <100.00%> (ø)
common/quotas/permember.go 100.00% <100.00%> (ø)
common/quotas/ratelimiter.go 82.53% <100.00%> (+3.69%) ⬆️
common/quotas/global/collection/collection.go 83.63% <66.66%> (-1.39%) ⬇️

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1771349...05c121e. Read the comment docs.

@dkrotx
Copy link
Member

dkrotx commented Sep 12, 2024

I think the commit-message isn't aligned with the change. I would expect more like tweaking constants for ratelimit-burst-size. Is it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants