Fix ListBatchJobs unit-test for Go 1.23+ #6547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This happened because our assumption of dates in CLI is always UTC, but we did't ask for this explicitely.
dkrotx
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
shijiesheng and
sankari165
as code owners
davidporter-id-au
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Fixed unit-tests running with Go 1.23
Why?
This happened because our assumption of dates in CLI is always UTC, but we
did't ask for this explicitely.
How did you test it?
Potential risks
There is no risk, since the dates conversion is a) cli-only b) we always assume UTC format by this test
Release notes
Documentation Changes