make test-cases explicit for IDE + subtest #6548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adding SetupSubTest/TearDownSubTest (requires testify 1.9.0) to make sure subtests are starting with their own test controllers. Otherwise adding a new test with different expectations on mocks could produce a misleading output. Also made test-cases visible for GoLand. It is able to run individual sub-tests when it sees `s.Run/t.Run` instruction in function.
dkrotx
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
shijiesheng and
sankari165
as code owners
sankari165
approved these changes
Dec 9, 2024
| }) | ||
| func (s *cliAppSuite) SetupSubTest() { | ||
| // this is required to re-establish mocks on subtest-level | ||
| // otherwise you will confusingly see expectations from previous test-cases on errors |
There was a problem hiding this comment.
urgh... I really don't like the suite method of testing :/
ty for the fix though, really annoying bug to fix in tests.
There was a problem hiding this comment.
Agree. I think it counters with Go idea that everything is explicit and there is no "magic". Suite definitely brings some. Unfortunately, there are so many tests that migrating seems too much of work.
...which reminds me, though - maybe I should just use ChatGPT for that!
davidporter-id-au
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
adding SetupSubTest/TearDownSubTest (requires testify 1.9.0) to make
sure subtests are starting with their own test controllers.
Otherwise adding a new test with different expectations on mocks could
produce a misleading output.
Also made test-cases visible for GoLand. It is able to run individual
sub-tests when it sees
s.Run/t.Runinstruction in function.Why?
Otherwise adding a new test with different expectations on mocks could
produce a misleading output.
How did you test it?
unit-tests
Potential risks
Release notes
Documentation Changes