Use dual indexer and separate consumers for OpenSearch migration #6559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neil-xie
requested review from
Shaddoll,
davidporter-id-au,
shijiesheng,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
| logger.Fatal("Secondary Index ES processor state changed", tag.LifeCycleStartFailed, tag.Error(err)) | ||
| } | ||
|
|
||
| secondaryConsumer, err := client.NewConsumer(common.VisibilityAppName, getConsumerName(secondaryVisibilityName+"-os")) |
There was a problem hiding this comment.
it would be better to define consumer names in the config. secondaryVisibilityName+"-os" looks a bit hidden behavior
There was a problem hiding this comment.
Yeah,I will update it. I am also not sure if OS should always use the name pattern *-os-consumer, since this can help when the migration is done and this extra consumer for OS will become the primary. Or we need to rename the consumer group to *-consumer to match the existing code.
Comment on lines
+408
to
+415
| if err := visibilityDualIndexer.SourceIndexer.Start(); err != nil { | ||
| visibilityDualIndexer.SourceIndexer.Stop() | ||
| s.GetLogger().Fatal("fail to start source indexer", tag.Error(err)) | ||
| } | ||
|
|
||
| if err := visibilityDualIndexer.DestIndexer.Start(); err != nil { | ||
| visibilityDualIndexer.DestIndexer.Stop() | ||
| s.GetLogger().Fatal("fail to start dest indexer", tag.Error(err)) |
There was a problem hiding this comment.
service doesn't need to know these source/dest indexers. the interface could stay the same from service perspective and the migration-dual-indexer can start/stop these
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Added dual indexer which contains 2 indexer to handle write operation to ES/OS
Each indexer will has its own consumer, so ES and OS can ack/nack kafka messages independently
Remove the migration indexer
Will land this after the changes in monorepo
Why?
OpenSearch migration
How did you test it?
Manual test to verify
Unit test
Potential risks
Release notes
Documentation Changes