-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor pycgmKinetics.py to kinetics.py #92
Draft
khgaw
wants to merge
16
commits into
cadop:dev-refactor-4x4s
Choose a base branch
from
khgaw:dev-kinetics
base: dev-refactor-4x4s
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khgaw
changed the title
Refactor of pycgmKinetics.py
Refactor of first half of pycgmKinetics.py
Apr 20, 2021
khgaw
changed the title
Refactor of first half of pycgmKinetics.py
Refactor pycgmKinetics.py to kinetics.py
Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of PR:
This PR refactors pycgmKinetics.py. This PR removes and fixes any functions that can be replaced with the numpy version.
What issues does this PR close:
PEP8 formatting
Refactoring functions
What files were changed and what changes were made?
init.py - created to run pytest
kinetics.py - fixed PEP8 formatting, removed vector() which is similar to np.subtract() (and fixed the differences in the rest of the code) and removed add() which is the same as np.add(). Combined smaller functions into get_kinetics(). Changed find_L5 function to take in a 4x4 matrix for the axis
test_kinetics.py - Removed tests for functions that do not exist anymore, changed unit tests to round to 5 decimal places.
Does your PR (check all that applies):
Are there any errors/relevant logs in your code?
No
How has this been tested?
Run doctests/pytest