Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor pycgmKinetics.py to kinetics.py #92

Draft
wants to merge 16 commits into
base: dev-refactor-4x4s
Choose a base branch
from

Conversation

khgaw
Copy link
Contributor

@khgaw khgaw commented Apr 20, 2021

Summary of PR:

This PR refactors pycgmKinetics.py. This PR removes and fixes any functions that can be replaced with the numpy version.

What issues does this PR close:

PEP8 formatting
Refactoring functions

What files were changed and what changes were made?

init.py - created to run pytest
kinetics.py - fixed PEP8 formatting, removed vector() which is similar to np.subtract() (and fixed the differences in the rest of the code) and removed add() which is the same as np.add(). Combined smaller functions into get_kinetics(). Changed find_L5 function to take in a 4x4 matrix for the axis
test_kinetics.py - Removed tests for functions that do not exist anymore, changed unit tests to round to 5 decimal places.

Does your PR (check all that applies):

  • Add documentation
  • Change/Remove documentation
  • Add tests
  • Change/Remove tests
  • Add code
  • Change/Remove code
  • Fix formatting

Are there any errors/relevant logs in your code?

No

How has this been tested?

Run doctests/pytest

@khgaw khgaw changed the title Refactor of pycgmKinetics.py Refactor of first half of pycgmKinetics.py Apr 20, 2021
@khgaw khgaw marked this pull request as ready for review April 20, 2021 16:03
@khgaw khgaw marked this pull request as draft April 21, 2021 20:37
@khgaw khgaw changed the title Refactor of first half of pycgmKinetics.py Refactor pycgmKinetics.py to kinetics.py Apr 26, 2021
@khgaw khgaw marked this pull request as ready for review April 28, 2021 15:40
@khgaw khgaw marked this pull request as draft May 4, 2021 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant