(WIP) Blitzblit meta-effect #78
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AltairQ Please fix Python formatting errors ;-) |
cahirwpz
reviewed
Feb 25, 2022
| static __data_chip u_short bplbuf0[BB_BPR * BB_HEIGHT / 2]; | ||
| static __data_chip u_short bplbuf1[BB_BPR * BB_HEIGHT / 2]; | ||
|
|
||
| static BitmapT bitbuf0 = { |
There was a problem hiding this comment.
I guess you could use NewBitmap function to achieve the same?
|
|
||
| // nonblocking | ||
| static void BLITZ_Load(u_short idx) { | ||
| (void)idx; |
There was a problem hiding this comment.
What was your intent to put idx into function parameters ?
| custom->bltalwm = LastWordMask[1]; | ||
|
|
||
| // SHIFT A MINTERM | ||
| custom->bltcon0 = rorw((uint16_t)1, 4) | SRCA | SRCB | SRCC | DEST | (minterm_curr & 0xff); |
There was a problem hiding this comment.
Please use ASHIFT and BSHIFT macros.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.