Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

seperate hashing with no concat and fix "hash" option #11

Merged
merged 1 commit into from
May 15, 2024
Merged

Conversation

theo-barfoot
Copy link
Collaborator

Summary of Changes:

Previous State:

The previous HTML file had the following behaviour:

  • The "hash and exclude" option concatenated all selected columns and hashed them together.
  • The "hash" option did not hash the contents of the column, but just an empty string

Changes Made:

Separate Hashing for Each Column:

  • Modified the code to hash each selected column separately instead of concatenating them.
  • Added a new column with the original column name suffixed by "_hash" for each hashed column.

Handling Options Correctly:

  • Hash: Added a new column with the hashed value (column name suffixed with "_hash") and retained the original column, fixing "Hash" only option doesn't seem to work as expected. #10
  • Hash and Exclude: Added a new column with the hashed value (column name suffixed with "_hash") and removed the original column from the unidentifiable spreadsheet.

Added Hash Input Box:

NOTE: This feature was already added to the main branch as it was a solution required in real time

  • Added a new section with a text input box and a button to hash the input using SHA-1.
  • Displayed the first 10 characters of the hash below the input box when the button is clicked.

@theo-barfoot theo-barfoot merged commit 4042183 into main May 15, 2024
@theo-barfoot theo-barfoot deleted the tb_fixes branch May 16, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant