(#310) Resolve windows binary only on windows

cake-contrib · May 4, 2024 · 52c308e · 52c308e
1 parent 4ee4916
commit 52c308e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/Source/Cake.Codecov.Tests/CodecovRunnerFixture.cs b/Source/Cake.Codecov.Tests/CodecovRunnerFixture.cs
@@ -1,3 +1,4 @@
+using System.Runtime.InteropServices;
 using Cake.Codecov.Internals;
 using Cake.Testing.Fixtures;
 
@@ -8,7 +9,7 @@ internal class CodecovRunnerFixture : ToolFixture<CodecovSettings>
         private readonly IPlatformDetector _platformDetector;
 
         public CodecovRunnerFixture()
-            : base("codecov.exe")
+            : base(RuntimeInformation.IsOSPlatform(OSPlatform.Windows) ? "codecov.exe" : "codecov")
         {
         }
 
@@ -20,9 +21,9 @@ public CodecovRunnerFixture(IPlatformDetector platformDetector, string expectedE
 
         protected override void RunTool()
         {
-            var tool = _platformDetector != null ?
-                new CodecovRunner(_platformDetector, FileSystem, Environment, ProcessRunner, Tools) :
-                new CodecovRunner(FileSystem, Environment, ProcessRunner, Tools);
+            var tool = _platformDetector != null
+                ? new CodecovRunner(_platformDetector, FileSystem, Environment, ProcessRunner, Tools)
+                : new CodecovRunner(FileSystem, Environment, ProcessRunner, Tools);
             tool.Run(Settings);
         }
     }

diff --git a/Source/Cake.Codecov/CodecovRunner.cs b/Source/Cake.Codecov/CodecovRunner.cs
@@ -55,10 +55,11 @@ protected override IEnumerable<string> GetToolExecutableNames()
             }
             else
             {
-                // Just to make sonarlint happy :)
+                // The official version of Codecov CLI can not run with the exe
+                // on anything other than Windows. As such we only return this
+                // in the else statement.
+                yield return "codecov.exe";
             }
-
-            yield return "codecov.exe";
         }
 
         protected override string GetToolName() => "Codecov";