(#979) Add support for new transifex client #981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdmiringWorm
force-pushed
the
feature/new-tx-support
branch
from
d6b85c9
to
67e6d13
Compare
gep13
force-pushed
the
feature/new-tx-support
branch
from
67e6d13
to
0d57802
Compare
|
@AdmiringWorm thank you for getting this fixed up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old transifex-client that was previously supported has stopped working some time ago, the new executable that replaces it is not fully compatibly with how we set up the api token when connecting to transifex.
This new executable also adds support for new global arguments where the token can be specified with, and as such this PR updates cake.recipe to be compatible with this new executable.
The changes are made directly here in Cake.Recipe instead of in Cake.Transifex for the global argument, as it won't be backported to be supported on older versions of Cake.
fixes #979