add halfOfYear, isFirstHalfOfYear, IsSecondHalfOfYear; improve getter… #421
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to propose the inclusion of the
halfOfYear
property and theisFirstHalfOfYear
andisSecondHalfOfYear
methods. The first half of the year corresponds to the first 6 months, while the second half corresponds to the remaining months.Furthermore, I've made some improvements to the type hinting of the read-only properties in order to specify the numeric range. For example, changing
daysInMonth
fromint
toint<1, 31>
. This allows for better static code analysis by PHPStan and Psalm.Thank you in advance.