Align Chronos::getTimezone() return type with DateTimeImmutable #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
othercorey
force-pushed
the
gettimezone-return
branch
from
280b445
to
1cc8f25
Compare
othercorey
commented
Sep 23, 2023
| return parent::getTimezone() ?: null; | ||
| $tz = parent::getTimezone(); | ||
| if ($tz === false) { | ||
| throw new RuntimeException('Time zone could not be retrieved.'); |
There was a problem hiding this comment.
I don't think it's possible to trigger this and just reflects the internal timelib functions. Maybe if you serialized DateTimeImmutable with a time zone that was later removed? I'm not sure.
There was a problem hiding this comment.
Meh, I wouldn't worry about getting coverage on this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids breaking compatibility and the need for an attribute.