Fix casting to string for ChronosDate and ChronosTime. #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make all classes explicitly implemement Stringable as recommeneded by the PHP docs.
ADmad
commented
Sep 24, 2023
| @@ -32,7 +32,7 @@ trait FormattingTrait | |||
| */ | |||
| public static function resetToStringFormat(): void | |||
| { | |||
| static::setToStringFormat(Chronos::DEFAULT_TO_STRING_FORMAT); | |||
| static::setToStringFormat(static::DEFAULT_TO_STRING_FORMAT); | |||
There was a problem hiding this comment.
Before this fix and addition of the constant to ChronosDate, calling ChronosDate::__toString() after ChronosDate::resetToStringFormat() returned value in Y-m-d H:i:s format instead of H:i:s.
othercorey
reviewed
Sep 24, 2023
| * | ||
| * @return void | ||
| */ | ||
| public static function resetToStringFormat(): void |
There was a problem hiding this comment.
We probably never needed the reset helpers since you can pass the constant to set directly.
There was a problem hiding this comment.
I just made it consistent with the other 2 classes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make all classes explicitly implemement Stringable as recommeneded by the PHP docs.