Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve exception messages #447

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Improve exception messages #447

merged 2 commits into from
Nov 3, 2023

Conversation

dereuromark
Copy link
Member

@dereuromark dereuromark commented Nov 1, 2023

1) Data\Test\TestCase\Model\Table\AddressesTableTest::testTouch
InvalidArgumentException: Time string is not in expected format: "HH[:.]mm" or "HH[:.]mm[:.]ss.u".

/home/runner/work/cakephp-data/cakephp-data/vendor/cakephp/chronos/src/ChronosTime.php:122

hard to understand

it is possible to give the values for quicker debugging however.

InvalidArgumentException: Time string `-2 seconds` is not in expected format `HH[:.]mm` or `HH[:.]mm[:.]ss.u`.

fixed also some formatting around code fencing.

src/Chronos.php Outdated Show resolved Hide resolved
Co-authored-by: Edgaras Janušauskas <[email protected]>
@markstory markstory added this to the 3.x milestone Nov 3, 2023
@markstory markstory merged commit 7dbd05d into 3.x Nov 3, 2023
6 of 7 checks passed
@markstory markstory deleted the fix-exception-messages branch November 3, 2023 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants