Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: benefits command line interface #2496

Draft
wants to merge 14 commits into
base: refactor/field-defaults
Choose a base branch
from
Draft

Feat: benefits command line interface #2496

wants to merge 14 commits into from

Conversation

thekaveman
Copy link
Member

No description provided.

@github-actions github-actions bot added tests Related to automated testing (unit, UI, integration, etc.) back-end Django views, sessions, middleware, models, migrations etc. docker Application container, devcontainer, Compose, etc. labels Oct 31, 2024
@thekaveman thekaveman self-assigned this Oct 31, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 31, 2024 •
edited
Loading

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  benefits/cli
  apps.py
  commands.py 49, 61, 104-105, 121-127
  main.py 3-21
  benefits/cli/agency
  create.py 24, 26, 43, 49, 65-72, 112-114
  list.py 52-53, 56
  benefits/cli/management/commands
  agency.py
Project Total  

This report was generated by python-coverage-comment-action

@thekaveman thekaveman force-pushed the feat/cli branch 2 times, most recently from d611257 to f9dd8a0 Compare October 31, 2024 05:44
@thekaveman
chore(models): TransitAgency eligibility api fields are optional
bc28c2c 
slug field is a SlugField for validation
@thekaveman
refactor(models): simplify template fields on TransitAgency
4c0c70b 
- compute template fields by default
- allow overriding templates
@thekaveman
refactor(models): simplify template fields on EnrollmentFlow
ff4d8fd 
- compute some template fields by default
- allow overriding templates
@thekaveman
chore(models): add blank=True for optional group, label
1479c3b
@thekaveman
refactor(models): default agency card templates
0e4c913 
further simplify template requirements for flows

rename agency card templates into standard naming pattern:

  {prefix}--{agency.slug}--agency-card.html

where {prefix} is e.g. eligibility/start or enrollment/success
@thekaveman
refactor(models): more field defaults for TransitAgency
dd0eb4e 
- use CST defaults for user-facing fields
- allow blanks for config fields
- remove null from TextField, not needed when blank=True
@thekaveman
feat(models): validate active TransitAgency
2ae5d8f 
when active=True, validate that:

- there are values for user-facing info fields like names, phone, etc.
- templates exist
@thekaveman thekaveman force-pushed the refactor/field-defaults branch 3 times, most recently from 56165d4 to 6012bff Compare November 6, 2024 00:44
@thekaveman thekaveman force-pushed the refactor/field-defaults branch 2 times, most recently from 321538f to 7759cc7 Compare November 12, 2024 23:16
@thekaveman thekaveman force-pushed the refactor/field-defaults branch 4 times, most recently from 9abea1b to 6bed021 Compare November 19, 2024 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thekaveman thekaveman

Labels
back-end Django views, sessions, middleware, models, migrations etc. docker Application container, devcontainer, Compose, etc. tests Related to automated testing (unit, UI, integration, etc.)
Projects
None yet
Milestone
Admin tool: agency configuration
Development

Successfully merging this pull request may close these issues.
1 participant
@thekaveman