Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Summer 2024: Portfolio README.md Template #1158

Merged
merged 3 commits into from
Jul 1, 2024
Merged

Refactor Summer 2024: Portfolio README.md Template #1158

merged 3 commits into from
Jul 1, 2024

Conversation

amandaha8
Copy link
Contributor

@amandaha8
Copy link
Contributor Author

@edasmalchi I opened up a pull request since I thought it would be easier for us to comment and make changes here.

@github-actions GitHub Actions
Copy link

nbviewer URLs for impacted notebooks:

edasmalchi
edasmalchi approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@edasmalchi edasmalchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amandaha8 made some small edits to the template and updated the portfolio script to make an index folder if necessary. If the edits look good to you feel free to merge, thanks so much :)

@amandaha8 amandaha8 merged commit 1e87993 into main Jul 1, 2024
2 checks passed
@amandaha8 amandaha8 deleted the portfolio_template branch July 1, 2024 19:25
This was referenced Jul 16, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edasmalchi edasmalchi edasmalchi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amandaha8 @edasmalchi