-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mdformat to precommit #2906
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SorenSpicknall
commented
Aug 24, 2023
SorenSpicknall
requested review from
atvaccaro,
lauriemerrell and
charlie-costanzo
as code owners
August 24, 2023 16:00
6 tasks
atvaccaro
approved these changes
Aug 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm except for one regex recommendation
I'm not sure of a good way to test this except by manually comparing all of the rendered pages :(
6 tasks
Closing in favor of #2923 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Automatically lint changed markdown files in the repo during precommit. Will supersede #2897 if accepted. This PR includes an initial repo-wide run of the new tool with some small hand fixes (specifically, Kubernetes -> architecture and Kubernetes -> deployment in the Developers section of the docs site had some empty headers that needed to be filled in).
Type of change
How has this been tested?
Testing has already taken place locally, and will take place on this PR while open.
Post-merge follow-ups