Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump calitp data analysis to 2024.2.6 #3268

Merged
merged 9 commits into from
Feb 7, 2024
Merged

Conversation

tiffanychu90
Copy link
Member

Description

Follow-up PR to #3267 and update calitp_data_analysis to 2024.2.6. Also update analytics_tools/python_libraries docs to iron out mypy details in making changes to calitp_data_analysis.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

How has this been tested?

In a notebook, imported the new version of calitp_data_analysis successfully.

Post-merge follow-ups

Document any actions that must be taken post-merge to deploy or otherwise implement the changes in this PR (for example, running a full refresh of some incremental model in dbt). If these actions will take more than a few hours after the merge or if they will be completed by someone other than the PR author, please create a dedicated follow-up issue and link it here to track resolution.

  • No action required
  • Actions required (specified below)

Copy link

github-actions bot commented Feb 7, 2024

@SorenSpicknall
Copy link
Contributor

SorenSpicknall commented Feb 7, 2024

The last step here is to make sure the new calitp-data-analysis version is added to the jupyter-singleuser poetry.lock file, which you can do by running poetry add [email protected] in the images/jupyter-singleuser folder of the repository to reflect the change you made in pyproject.toml. poetry.lock is edited solely through Poetry commands, rather than by hand, and is generated based on the contents of pyproject.toml.

The currently failing CI task is saying it can't find the new package version because Poetry looks for the version within a pre-generated list of available versions in poetry.lock, rather than looking live on PyPI itself. Once you run the command to update poetry.lock and commit the changed lockfile, the CI task should find the new calitp-data-analysis package version just fine.

@tiffanychu90 tiffanychu90 merged commit 39aac15 into main Feb 7, 2024
4 checks passed
@tiffanychu90 tiffanychu90 deleted the bump-calitp-data-analysis branch February 7, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants