Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add seed table for ntd_id (2022) and (organization) source_record_id #3366

Closed
wants to merge 2 commits into from

Conversation

tiffanychu90
Copy link
Member

Description

Try another approach at getting ntd_id_2022 added without truncating to 5 digits in every query. Add a seed table to help us bridge ntd_id_2022 with dim_organizations.source_record_id.

Follow-up to #3364
Resolves #[issue]

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

How has this been tested?

Include commands/logs/screenshots as relevant.

Post-merge follow-ups

Document any actions that must be taken post-merge to deploy or otherwise implement the changes in this PR (for example, running a full refresh of some incremental model in dbt). If these actions will take more than a few hours after the merge or if they will be completed by someone other than the PR author, please create a dedicated follow-up issue and link it here to track resolution.

  • No action required
  • Actions required (specified below)

@tiffanychu90 tiffanychu90 marked this pull request as draft June 6, 2024 18:31
@vevetron
Copy link
Contributor

vevetron commented Jun 6, 2024

I don't think we should go down this path of adding seeds for ntd_ids of data that exists in airtable already.

@tiffanychu90
Copy link
Member Author

@vevetron: yes, that's fine that we don't go down this path! closing this PR, but now we know how to add seed tables

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants