fix(ci): update gtfs-rt-archiver-v3 tagging and docs #3455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
themightychris
requested review from
evansiroky and
vevetron
as code owners
ohrite
approved these changes
Sep 13, 2024
There was a problem hiding this comment.
🍐 Paired to review with @themightychris
More SHA = more good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The docs on how to deploy the
gtfs-rt-archiver-v3image were out of date, and the workflow was prone to unexpectedly updating the already-deployed container image if thepyproject.tomlversion hadn't been manually updated.For example, upon merging a dependabot PR that makes changes to
services/gtfs-rt-archiver-v3/*and new image would get built and pushed over the already-deployed container image tag, leading production instances to start using the new version without any verification step or the designed manual new version deployment.This change appends the short SHA to the container tag as a build number suffix, ensuring that each is build is uniquely identified and must be intentionally deployed to production.
Type of change
How has this been tested?
In a forked repo
Post-merge follow-ups