Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: manually add cleverapi.bigbluebus.com intermediate certificate to image #3457

Closed
wants to merge 1 commit into from
Closed

fix: manually add cleverapi.bigbluebus.com intermediate certificate to image #3457

wants to merge 1 commit into from

Conversation

themightychris
Copy link
Contributor

@themightychris themightychris commented Sep 13, 2024 •
edited by ohrite
Loading

Description

Provides a short-term fix to #3452.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

How has this been tested?

Running curl -vvvv https://cleverapi.bigbluebus.com/ within the locally-built container image

Post-merge follow-ups

  • Deploy new image tag to cluster

@ohrite ohrite mentioned this pull request Sep 13, 2024
Closed
evansiroky
evansiroky reviewed Sep 21, 2024
View reviewed changes
Copy link
Member

@evansiroky evansiroky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's likely that this won't be merged given that we generally don't want to have to add custom certificates to what should be generic HTTP requests. That being said, this proof-of-concept is a helpful demonstration.

@vevetron vevetron closed this Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evansiroky evansiroky evansiroky left review comments

@vevetron vevetron Awaiting requested review from vevetron vevetron is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@themightychris @evansiroky @vevetron