Review NTD Validation models

[erikamov]

Description

This PR is a continuation of the work on #3483 to update the NTD validation models for 2024 and next years:

• Added new columns requested by Christian Suyat on external table all_ntdreports.
• Fixed some issues on NTD validation models:
  • Division by zero error: Added new clauses on fct_ntd_rr20_service_checks to verify if the values are not NULL or Zero before the calculation, and fixed ROUND function to use only at the end of the calculation.
  • Blank value_checked results: Replaced NULL values by " " (space) to make the Concatenation function to return the existing values on fct_ntd_rr20_service_checks, fct_ntd_a30_vomscheck.
  • Blank Organizations: Return Organization names from last year table when the Organization does not exist in the current year on int_ntd_a30_voms_vins_totals
  • No information about the year: Added year_of_data column on fct_ntd_a30_vomscheck

Note: As much as I want to fix indentation and some patterns on those files, I couldn't change much because it was making hard to see the real changes (GIT DIFF).

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation

How has this been tested?

Tested locally creating tables on Staging:

• cal-itp-data-infra-staging.external_blackcat.all_ntdreports
• cal-itp-data-infra-staging.erika_mart_ntd_validation.fct_ntd_rr20_service_checks
• cal-itp-data-infra-staging.erika_mart_ntd_validation.fct_ntd_a30_vomscheck
• cal-itp-data-infra-staging.erika_staging.int_ntd_a30_voms_vins_totals

Post-merge follow-ups

• No action required
• Actions required (specified below)

Review the fixes on production after the next DAG transform_warehouse runs.

• cal-itp-data-infra.external_blackcat.all_ntdreports
• cal-itp-data-infra.mart_ntd_validation.fct_ntd_rr20_service_checks
• cal-itp-data-infra.mart_ntd_validation.fct_ntd_a30_vomscheck
• cal-itp-data-infra.staging.int_ntd_a30_voms_vins_totals

[github-actions]

Warehouse report 📦

DAG

Legend (in order of precedence)

Resource type	Indicator	Resolution
Large table-materialized model	Orange	Make the model incremental
Large model without partitioning or clustering	Orange	Add partitioning and/or clustering
View with more than one child	Yellow	Materialize as a table or incremental
Incremental	Light green
Table	Green
View	White