Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pull_request_template.md to include testing instructions for changes to dbt models #3505

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

evansiroky
Copy link
Member

Description

Include additional guidance on how to test changes made to dbt models.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

How has this been tested?

N/A

Post-merge follow-ups

Document any actions that must be taken post-merge to deploy or otherwise implement the changes in this PR (for example, running a full refresh of some incremental model in dbt). If these actions will take more than a few hours after the merge or if they will be completed by someone other than the PR author, please create a dedicated follow-up issue and link it here to track resolution.

  • No action required
  • Actions required (specified below)

Make announcement in change in procedure to slack.

Copy link
Contributor

@vevetron vevetron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I Agree.

@erikamov
Copy link
Contributor

I was already using this command to make sure the model can be successfully created and works on Staging and mentioning the staging model name on my PRs to help the approval process.
Adding the log in PRs sounds easy enough and it is a good way to make sure that was tested.

Include additional guidance on how to test changes made to dbt models.
@evansiroky evansiroky merged commit 9ae4e70 into main Oct 25, 2024
1 check passed
@evansiroky evansiroky deleted the evansiroky-patch-1 branch October 25, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants