Deploy to test #355

angela-tran · 2023-10-26T19:11:00Z

No description provided.

github.ref_name covers getting either branch _or tag_ name, so with this commit, a run of this workflow would publish a Docker tag with the git tag name

also set 'cancel-in-progress' to true so that pending runs will cancel if a newer run is queued for a given concurrency group

the workflow itself is already filtered to only listen to release publishes

maintain access to healthcheck endpoint

put the expression back as inline values instead of being a variable

backend configuration cannot use named values such as variables

remove Build Status badge; it seems to not render correctly

update README to point to online documentation

updates: - [github.com/psf/black: 23.9.1 → 23.10.0](psf/black@23.9.1...23.10.0)

this will rename MST's key vault

thekaveman · 2023-10-26T19:18:48Z

~~Can we make #253 go as part of this cycle?~~

Nevermind we're not going to try and do this at the same time.

thekaveman · 2023-10-26T23:35:52Z

@angela-tran the plan failed, is that expected?

Error: Instance cannot be destroyed
│
│ on key_vault.tf line 1:
│ 1: resource "azurerm_key_vault" "main" {
│
│ Resource azurerm_key_vault.main has lifecycle.prevent_destroy set, but the
│ plan calls for this resource to be destroyed.

Seems like the same message as before?

thekaveman · 2023-10-26T23:42:36Z

Is this where we need to soft-delete the key vault and not worry since we're not trying to reuse the name anyway?

angela-tran · 2023-10-26T23:43:37Z

@angela-tran the plan failed, is that expected?

Error: Instance cannot be destroyed
│
│ on key_vault.tf line 1:
│ 1: resource "azurerm_key_vault" "main" {
│
│ Resource azurerm_key_vault.main has lifecycle.prevent_destroy set, but the
│ plan calls for this resource to be destroyed.

Seems like the same message as before?

Right, it's the same message as when we plan'd the change in #354 for dev. So now we need to do the same process of manually deleting the Key Vault (this time the one named eligibility-server-test) and setting the secret again in the new mst-courtesy-card-test Key Vault

angela-tran and others added 30 commits September 26, 2023 19:23

feat: add event trigger for when pre-releases or releases are published

00d39d0

github.ref_name covers getting either branch _or tag_ name, so with this commit, a run of this workflow would publish a Docker tag with the git tag name

refactor: make pre-releases/releases use the correct deploy environment

ade17c6

refactor: move concurrency config to workflow level instead of job level

d613425

also set 'cancel-in-progress' to true so that pending runs will cancel if a newer run is queued for a given concurrency group

feat: make git hash available in static file

c93ac27

Feat: make git hash available in static file (#335)

f4dcaca

feat: pipdeptree to a static file

340f2b2

fix: add step to create static directory needed for various static files

c3c010c

Feat: pipdeptree (#336)

02063e8

feat: run tests before deploying if triggered by pre-release/release

9218a01

refactor: remove unneeded conditions from test if expression

07a2e2e

the workflow itself is already filtered to only listen to release publishes

refactor: extract out deploy-environment name as environment variable

1ec8099

feat: create Docker tag with deployment environment name

f36ca19

refactor: remove unneeded and redundant usage of always()

659c5c8

chore: add comment explaining 'deploy' job condition

0586d73

feat(frontdoor): allow access to static files dir

874473a

maintain access to healthcheck endpoint

Feat: deploy for pre-release or release (#329)

b910707

fix: 'env' context is not available in the places we need it

e1b4e08

put the expression back as inline values instead of being a variable

Feat: allow access to static files dir (#338)

382cc09

Fix: inline expression for deployment environment (#339)

ba9af5a

fix: custom rule names can only consist of letters and numbers

f530f36

Fix: custom rule name (#341)

9e32f19

refactor: move pipeline stages out into template

f9ecd71

refactor: extract out agency-specific name

26b95e5

chore: format template code

393953a

refactor: variables don't work in templates, try pipeline

01b2936

chore: fix syntax for using variable in expression

100697e

chore: prevent this noise from appearing in terraform plan

bc2379a

refactor: variablize Terraform state resources

2ea9a89

refactor: extract out subscription name from init script

ee93b21

fix: move agency-specific backend configuration to command options

3803ffa

backend configuration cannot use named values such as variables

angela-tran and others added 20 commits October 10, 2023 22:52

chore: reorder variables to be more organized

dbe9111

chore: make description for ETL app object ID variable more generic

50fbd28

refactor(terraform): extract separate variable for resource group name

e1ae46e

chore: make naming more consistent

c22124e

Feat: agency-specific Terraform variables (#346)

05a7f35

feat: add files for local development of SBMTD Terraform

7f81779

feat: add SBMTD-specific pipeline definition and variables

93bf003

docs(infra): update access restrictions to mention /static path

9514c56

docs(infra): update docs on init script taking agency param

b165ec6

docs(infra): update docs that mention environment resource groups

f871893

remove Build Status badge; it seems to not render correctly

docs(infra): update reference to Terraform version location

4a35baf

docs(infra): add details on steps to be done manually

8c713d2

docs(infra): move terraform README into docs file structure

7f547e2

update README to point to online documentation

chore(pre-commit): autoupdate hooks

2eacbad

updates: - [github.com/psf/black: 23.9.1 → 23.10.0](psf/black@23.9.1...23.10.0)

docs: add steps about requesting parallelism grant

eb82b9b

Docs: infrastructure (#350)

a488cc6

chore(pre-commit): autoupdate hooks (#351)

1fd6140

Feat: SBMTD infra pipeline (#349)

81976d1

fix: use agency card as prefix for key vault name

2ecb49c

this will rename MST's key vault

Fix: use agency card as prefix for key vault name (#354)

3f49b0f

angela-tran added this to the SBMTD Mobility Pass milestone Oct 26, 2023

angela-tran self-assigned this Oct 26, 2023

angela-tran requested a review from a team as a code owner October 26, 2023 19:11

thekaveman approved these changes Oct 26, 2023

View reviewed changes

angela-tran merged commit b213928 into test Oct 26, 2023
13 checks passed

angela-tran mentioned this pull request Oct 31, 2023

Feat: Sentry error monitoring #253

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Deploy to test #355

Deploy to test #355

angela-tran commented Oct 26, 2023

thekaveman commented Oct 26, 2023 •

edited

Loading

thekaveman commented Oct 26, 2023

thekaveman commented Oct 26, 2023

angela-tran commented Oct 26, 2023

Deploy to test #355

Deploy to test #355

Conversation

angela-tran commented Oct 26, 2023

thekaveman commented Oct 26, 2023 • edited Loading

thekaveman commented Oct 26, 2023

thekaveman commented Oct 26, 2023

angela-tran commented Oct 26, 2023

thekaveman commented Oct 26, 2023 •

edited

Loading