Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: automate GitHub releases #11

Merged
merged 19 commits into from
Nov 3, 2023
Merged

Feat: automate GitHub releases #11

merged 19 commits into from
Nov 3, 2023

Conversation

thekaveman
Copy link
Member

@thekaveman thekaveman commented Oct 23, 2023 •
edited
Loading

Closes #9

Decided against PyPI publishing for now, to help alleviate some of the concerns raised earlier this week.

@github-actions
Copy link

Coverage report

The coverage rate went from 98.22% to 98.22% ➡️
The branch rate is 98%.

100% of new lines are covered.

Diff Coverage details (click to unfold)

littlepay/init.py

100% of new lines are covered (60% of the complete file).

@thekaveman thekaveman added this to the Back Office API Enrollment milestone Oct 24, 2023
@thekaveman thekaveman self-assigned this Oct 24, 2023
@thekaveman
Copy link
Member Author

thekaveman commented Oct 24, 2023 •
edited
Loading

The automatic GitHub Release works as expected 👍 e.g.

@thekaveman
chore(ci): remove duplicate release file
1691b06 
source is automatically attached to each release
continue to attach the generated wheel
@thekaveman
fix(pyproject): relax python version requirement
6dc6e49
@thekaveman
ci(test): test with Python >= 3.10
2e28687 
re-use the pytest.yml workflow in release.yml
@thekaveman
fix(ci): build release with Python 3.11
67249eb
@thekaveman
fix(pyproject): don't lock dependencies
58ef086 
bad practice for a library
@thekaveman thekaveman changed the title Feat: automate GitHub and PyPI releases Feat: automate GitHub releases Nov 3, 2023
@thekaveman thekaveman requested a review from a team November 3, 2023 16:58
@thekaveman
chore(release): simplify tag matching
ecc7b45 
more generic, but easier to grok
@thekaveman thekaveman added documentation Improvements or additions to documentation actions Related to GitHub Actions workflows labels Nov 3, 2023
angela-tran
angela-tran approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@angela-tran angela-tran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me

@thekaveman thekaveman merged commit e6592c4 into main Nov 3, 2023
3 checks passed
@thekaveman thekaveman deleted the feat/release branch November 3, 2023 19:14
@thekaveman thekaveman mentioned this pull request Mar 6, 2024
Closed
5 tasks
@thekaveman thekaveman mentioned this pull request Jul 12, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angela-tran angela-tran angela-tran approved these changes

Assignees

@thekaveman thekaveman

Labels
actions Related to GitHub Actions workflows documentation Improvements or additions to documentation
Projects
None yet
Milestone
Back Office API Enrollment
Development

Successfully merging this pull request may close these issues.

Prepare for publishing
2 participants
@thekaveman @angela-tran