Fix: allow unexpected fields in responses

[angela-tran]

Closes #66

This PR makes it so GET requests will allow unexpected fields in the response JSON. The main code changes was for Client._get to expect that it can call from_kwargs to instantiate the response object, and to add from_kwargs as a class method on all response dataclasses.

Looking at our Client code and usages of _get, _post, and _put, we see that it is really only _get that tries to hydrate specific response dataclasses. Endpoints that use _put and _post all pass in dict as the response class to hydrate.

So it is a sufficient fix to only change Client._get.

[github-actions]

Coverage report

Click to see where and how coverage changed

File	Statements	Missing	Coverage	Coverage (new stmts)	Lines missing
littlepay/api
__init__.py
client.py
funding_sources.py
groups.py
products.py
Project Total

This report was generated by python-coverage-comment-action

[angela-tran]

Just noticed a missing return

[angela-tran]

Ready for review!

[thekaveman]

Very nice 👍

[angela-tran]

I ran Benefits with this branch of littlepay and was able to get the log message for fields not defined in the dataclass:

[17/Sep/2024 10:35:08] INFO littlepay.api:39 Ran into an unexpected arg: created_date = 2023-10-05T00:15:19Z

Then I added created_date to the dataclass in b756c42... but I guess we're not actually using created_date anywhere, so maybe this change isn't actually needed. What are your thoughts @thekaveman?

[thekaveman]

@angela-tran

Then I added created_date to the dataclass in b756c42... but I guess we're not actually using created_date anywhere, so maybe this change isn't actually needed.

I think this is fine. It's a valid field now available in the API response, so we can parse it and make it available in case others are using our library.