Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For vendors: FAQ and Meet Your Market section #506

Merged

Conversation

machikoyasuda
Copy link
Member

@machikoyasuda machikoyasuda commented Dec 4, 2023

closes #495
closes #497

@machikoyasuda machikoyasuda marked this pull request as ready for review December 4, 2023 21:33
@machikoyasuda machikoyasuda requested a review from a team as a code owner December 4, 2023 21:33
@machikoyasuda machikoyasuda self-assigned this Dec 4, 2023
@machikoyasuda machikoyasuda changed the title For vendors: FAQ For vendors: FAQ and Stat section Dec 4, 2023
@machikoyasuda machikoyasuda changed the base branch from feat/495-for-vendors-header to feat/496-for-vendors-focus December 4, 2023 22:18
@machikoyasuda machikoyasuda changed the title For vendors: FAQ and Stat section For vendors: FAQ and Meet Your Market section Dec 4, 2023
@machikoyasuda machikoyasuda changed the base branch from feat/496-for-vendors-focus to feat/495-for-vendors-header December 4, 2023 22:23
@machikoyasuda
Copy link
Member Author

@thekaveman @angela-tran Ready for review.

I opted to just use the image for the statistics question. It would just have been way too hard to write a custom SVG.

@machikoyasuda machikoyasuda changed the base branch from feat/495-for-vendors-header to feat/496-for-vendors-focus December 6, 2023 22:30
@machikoyasuda machikoyasuda marked this pull request as draft December 6, 2023 22:36
Base automatically changed from feat/496-for-vendors-focus to feat/495-for-vendors-header December 7, 2023 01:02
Base automatically changed from feat/495-for-vendors-header to feat/499-for-vendors-newsletter December 7, 2023 01:03
@thekaveman
Copy link
Member

@machikoyasuda I think this one still needs to be completed, yeah?

@machikoyasuda
Copy link
Member Author

@thekaveman Yea this one will be ready for review tomorrow am.

@machikoyasuda machikoyasuda marked this pull request as ready for review December 7, 2023 01:40
@machikoyasuda
Copy link
Member Author

@segacy1 can I get a SVG for this? the PNG is blurry:
image

@segacy1
Copy link

segacy1 commented Dec 7, 2023

Stat here:

lg

@machikoyasuda
Copy link
Member Author

Looks nicer now thank you @segacy1 !

image

@machikoyasuda
Copy link
Member Author

@thekaveman This PR is now ready for review. Then, we'll have 1 last PR ready for review so we can merge For Vendors page to Prod.

Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@machikoyasuda machikoyasuda merged commit 4369e36 into feat/499-for-vendors-newsletter Dec 7, 2023
1 check passed
@machikoyasuda machikoyasuda deleted the feat/498-for-vendors-faq branch December 7, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[vendor page] Add new FAQ section [vendor page] Add new Meet your market section
3 participants