Convert YAML-based How-To pages to markdown #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cal-itp-mobility-marketplace ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
allejo
force-pushed
the
vlad/migrate-how-to-2-markdown
branch
from
d85b66f
to
9dd2230
Compare
machikoyasuda
approved these changes
Feb 13, 2024
There was a problem hiding this comment.
- Reviewed each page side by side for content, links, anchor links, tables
- Reviewed pages for accessibility - focus rings, focus/tab ordering, type
The 100?ish? lines of Liquid templating logic is truly incredible @allejo
|
Holy moly!! Very nice @allejo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because HTML is ugly already, now we're putting HTML inside of YAML? Not on my watch!
The pages affected by this PR are:
If I could get a pair of eyes to confirm I didn't lose any data in this port would be appreciated!
Closes #469