fix(nav): the for-vendors link can be set to current #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cal-itp-mobility-marketplace ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
angela-tran
approved these changes
Aug 13, 2024
There was a problem hiding this comment.
Nice fix and debugging! I verified it works as expected on the preview site.
I dug into why it's ok for /contracts/ to have a trailing slash: it's because contracts is a folder with an index.html file, and either Jekyll or Netlify is making it so there is a trailing slash in the URL when you go to the Contracts page.
The other pages are just an .html file, and this logic replaces the .html part (no trailing slash appended or anything).
machikoyasuda
force-pushed
the
fix/573-for-vendors
branch
from
e214348
to
518c980
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #573
There was a small bug in the menu code that was preventing the For Vendors link from being highlighted when you're on that page. The menu should highlight the current page you are on.
Branch Preview vs. Prod
Branch Preview https://deploy-preview-575--cal-itp-mobility-marketplace.netlify.app/for-vendors
Production
