Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix : can not get orders between date #49

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CasonMo
Copy link

@CasonMo CasonMo commented Feb 21, 2023

When I was using the wc-api-java sdk to call to wocommerce's get orders or get products api, I found that once the ISO8601 date was passed as a parameter, like this date: 2023-02-21T14:46:25, The following error will shown

{"code":"woocommerce_rest_authentication_error","message":"Invalid Signature-provided signature does not match.","data":{"status":401}}.

Later I found the following difference by comparing the official php sdk code.
php sdk url:https://packagist.org/packages/automattic/woocommerce

php sdk:
after%3D2023-02-21T13%253A00%253A23%26before%3D2023-02-21T13%253A00%253A23
java sdk:
after%3D2023-02-21T13%3A00%3A23%26before%3D2023-02-21T13%3A00%3A23

I found this problem the java sdk is not converting % to %25 when it executes the percentEncode() method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant